Support to run karmadactl init within a pod #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
kind/feature
karmada-bot
added
the
size/XS
|
Hi @hzxuzhonghu , Could you please help test it in your env? |
lonelyCZ
force-pushed
the
pr-incluster-config
branch
from
1873a17 to
4dcfea8
Compare
hzxuzhonghu
reviewed
Mar 28, 2023
| @@ -43,6 +44,13 @@ func RestConfig(context, kubeconfigPath string) (*rest.Config, error) { | |||
| kubeconfigPath = env.GetString("KUBECONFIG", defaultKubeConfig) | |||
| } | |||
| if !Exists(kubeconfigPath) { | |||
| klog.Warning("Neither --kubeconfig nor KUBECONFIG was specified and '~/.kube/config' doesn't exist. Using the inClusterConfig. This might not work.") | |||
| // if the kubeconfig path is not valid, try to load InClusterConfig | |||
| inClusterRestConfig, err := rest.InClusterConfig() | |||
hzxuzhonghu
approved these changes
Mar 28, 2023
Great, I will update the klog message to match our scenario. |
lonelyCZ
force-pushed
the
pr-incluster-config
branch
from
4dcfea8 to
9654407
Compare
lonelyCZ
changed the title
karmada-bot
removed
the
do-not-merge/work-in-progress
|
If there isn't kubeconfig, the message is that What do you think? /cc @RainbowMango |
|
/assign |
| @@ -43,6 +44,13 @@ func RestConfig(context, kubeconfigPath string) (*rest.Config, error) { | |||
| kubeconfigPath = env.GetString("KUBECONFIG", defaultKubeConfig) | |||
| } | |||
| if !Exists(kubeconfigPath) { | |||
| klog.Warningf("Kubeconfig '%s' doesn't exist. Using the inClusterConfig. This might not work.", kubeconfigPath) | |||
There was a problem hiding this comment.
Since we are going to officially support the in-cluster mode, we can think of this(build rest config by InClusterConfig) as a normal way, so, this log should not be a warning.
There was a problem hiding this comment.
How about this?
if !Exists(kubeconfigPath) {
// Given no kubeconfig is provided, give it a try to load the config by
// in-cluster mode if the client running inside a pod running on kubernetes.
host, port := os.Getenv("KUBERNETES_SERVICE_HOST"), os.Getenv("KUBERNETES_SERVICE_PORT")
if len(host) > 0 || len(port) > 0 { // in-cluster mode
inClusterRestConfig, err := rest.InClusterConfig()
if err != nil {
return nil, fmt.Errorf("failed to load rest config by in-cluster mode: %v", err)
}
return inClusterRestConfig, nil
}
return nil, ErrEmptyConfig
}If no kubeconfig is provided and it works inside a Pod, we assume that it is intended to be running inside, so we just return the in-cluster error.
Signed-off-by: lonelyCZ <chengzhe@zju.edu.cn>
lonelyCZ
force-pushed
the
pr-incluster-config
branch
from
9654407 to
59ef627
Compare
karmada-bot
added
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support to run karmadactl init within a pod by InClusterConfig.
Which issue(s) this PR fixes:
Fixes #3335
Special notes for your reviewer:
Does this PR introduce a user-facing change?: