-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specify global image registry for enable addons #3345
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3345 +/- ##
==========================================
+ Coverage 51.50% 51.54% +0.04%
==========================================
Files 210 210
Lines 18850 18874 +24
==========================================
+ Hits 9709 9729 +20
- Misses 8642 8644 +2
- Partials 499 501 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/cc @RainbowMango @Poor12 |
Signed-off-by: xin.li <xin.li@daocloud.io>
LGTM |
@Poor12: GitHub didn't allow me to request PR reviews from the following users: owner. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can you post the latest test result ? |
The test result: By default: |
/lgtm |
@my-git9 It seems lack of es ,can you add the es result ? |
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuyingjun-lucky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
If we use 'karmadactl addons init' to enable multiple addons, it is a good experience to specify a global image repository for all images.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: