-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CommandArgsOverrider supports Job #3414
Conversation
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
I just noticed that the |
Yes. |
By the way, i think we should support initContainers, not just containers. |
Yes, however, the API needs to be updated accordingly. |
It's ok to let this PR focus on the Job, have you tested it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
CommandArgsOverrider supports Job
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
karmada/pkg/util/overridemanager/imageoverride.go
Lines 66 to 71 in 4ed7010
Consistent with imageOverride.
Does this PR introduce a user-facing change?: