-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allows users to propagate resources under the Kubernetes reserved namespace. #3433
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3433 +/- ##
==========================================
- Coverage 51.73% 51.73% -0.01%
==========================================
Files 210 210
Lines 18948 18947 -1
==========================================
- Hits 9803 9802 -1
Misses 8602 8602
Partials 543 543
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
840d40f
to
60d6350
Compare
/cc @RainbowMango What do you think? |
60d6350
to
f14c106
Compare
…ed namespace. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
f14c106
to
1f42f7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks.
@yizhang-zen I assume you have no further comment :).
By the way, I updated the release note, hope you don't mind.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: chaunceyjiang chaunceyjiang@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
allows users to propagate resources under the Kubernetes reserved namespace.
Which issue(s) this PR fixes:
Fixes #3369
Special notes for your reviewer:
Does this PR introduce a user-facing change?: