Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows users to propagate resources under the Kubernetes reserved namespace. #3433

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

chaunceyjiang
Copy link
Member

@chaunceyjiang chaunceyjiang commented Apr 19, 2023

Signed-off-by: chaunceyjiang chaunceyjiang@gmail.com

What type of PR is this?
/kind feature

What this PR does / why we need it:

allows users to propagate resources under the Kubernetes reserved namespace.

Which issue(s) this PR fixes:
Fixes #3369

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: The `--skipped-propagating-namespaces` flags now can take regular expressions to represent namespaces and defaults to `kube-*`.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 19, 2023
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2023
@chaunceyjiang
Copy link
Member Author

karmada:

image

member clusters:

image

Compatible with the original logic.

@codecov-commenter
Copy link

Codecov Report

Merging #3433 (587283c) into master (2be4b33) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3433      +/-   ##
==========================================
- Coverage   51.73%   51.73%   -0.01%     
==========================================
  Files         210      210              
  Lines       18948    18947       -1     
==========================================
- Hits         9803     9802       -1     
  Misses       8602     8602              
  Partials      543      543              
Flag Coverage Δ
unittests 51.73% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/controller-manager/app/options/options.go 0.00% <0.00%> (ø)
pkg/util/names/names.go 96.42% <100.00%> (-0.05%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chaunceyjiang chaunceyjiang force-pushed the prefix-namespace branch 2 times, most recently from 840d40f to 60d6350 Compare April 19, 2023 10:57
@chaunceyjiang
Copy link
Member Author

chaunceyjiang commented Apr 19, 2023

image

/cc @RainbowMango What do you think?

…ed namespace.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks.

@yizhang-zen I assume you have no further comment :).

By the way, I updated the release note, hope you don't mind.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2023
@karmada-bot karmada-bot merged commit b118a73 into karmada-io:master Apr 21, 2023
@RainbowMango RainbowMango modified the milestones: v1.5, v1.6 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PropagationPolicy doesn't work when target resource is in kube-system namespace
5 participants