-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the issue of adding duplicate eviction tasks #3456
Conversation
/remove-kind bug |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3456 +/- ##
==========================================
+ Coverage 51.78% 53.75% +1.96%
==========================================
Files 210 210
Lines 18974 19118 +144
==========================================
+ Hits 9826 10276 +450
+ Misses 8605 8290 -315
- Partials 543 552 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me.
It'd be great if you can add a test case.
Signed-off-by: jwcesign <jiangwei115@huawei.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@XiShanYongYe-Chang
Do you think we need to skip the cluster during scheduling when the cluster already in eviction tasks?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Referring to the logic of K8s native scheduling, I think we need to try to schedule without the clusters in eviction tasks first. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
1.apply following yaml:
2.taint the cluster
3.check rb
The tasks will be added multiple times.
Which issue(s) this PR fixes:
Fixes #none
Special notes for your reviewer:
@XiShanYongYe-Chang
Does this PR introduce a user-facing change?: