-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introducing a karmadactl top command #3593
Conversation
4982e3d
to
e1dda27
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3593 +/- ##
==========================================
- Coverage 54.71% 54.69% -0.02%
==========================================
Files 229 229
Lines 22074 22074
==========================================
- Hits 12077 12074 -3
- Misses 9351 9354 +3
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more. |
1f92fa0
to
a4e738a
Compare
8a84be3
to
05de3a8
Compare
Can we push it forward? |
83c6ff6
to
f3246a8
Compare
/cc @jwcesign PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just some nits.
karmadactl has introduced a new column called "Cluster",
Two questions on that:
- I see the
Cluster
is present as the first column, have you ever considered putting it right after the pod name? Just likekarmadactl get
:
# karmadactl get pods -A
NAMESPACE NAME CLUSTER READY STATUS RESTARTS AGE
kube-system coredns-5d78c9869d-f98rf member1 1/1 Running 0 5d4h
kube-system coredns-5d78c9869d-j9znc member1 1/1 Running 0 5d4h
- Is the output sorted by default? I think it would be better to sort it first by cluster and then by resource name.
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
/cc @RainbowMango Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The difference between
kubectl
andkarmadactl
lies in the fact thatkarmadactl
has introduced a new column called "Cluster", which allows you to view the resource usage of pods in different clusters.Please see more details.
#3578 (comment)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: