cleanup FederatedHPA API #3712
cleanup FederatedHPA API #3712
Conversation
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/M
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3712 +/- ##
=======================================
Coverage 55.69% 55.69%
=======================================
Files 222 222
Lines 21195 21195
=======================================
Hits 11805 11805
Misses 8763 8763
Partials 627 627
Flags with carried forward coverage won't be shown. Click here to find out more. |
| // +optional | ||
| MinReplicas *int32 `json:"minReplicas,omitempty" protobuf:"varint,2,opt,name=minReplicas"` | ||
| MinReplicas *int32 `json:"minReplicas,omitempty"` |
There was a problem hiding this comment.
Do we need // +kubebuilder:default=1?
There was a problem hiding this comment.
This PR focuses on cleanup things.
If you want to add more validations, please send another PR.
Do we need // +kubebuilder:default=1?
I don't think so. We handled the default value at webhook.
https://github.com/karmada-io/karmada/blob/master/pkg/util/lifted/federatedhpa.go#L61-L63
RainbowMango
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: chaunceyjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR clean up some nits including field tags and comments.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: