fix: when application failover is enabled but propagateDeps is set to false, the failover has no effect

[chaunceyjiang]

Signed-off-by: chaunceyjiang chaunceyjiang@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #3738

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-webhook`: When application failover is enabled, users are prevented from setting propagateDeps to `false`.

[chaunceyjiang]

Test:

[chaunceyjiang]

/cc @Poor12 PTAL.

[Poor12]

/lgtm

[codecov-commenter]

Codecov Report

Merging #3739 (0b86e0d) into master (626564d) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3739      +/-   ##
==========================================
- Coverage   55.69%   55.67%   -0.03%     
==========================================
  Files         222      222              
  Lines       21195    21198       +3     
==========================================
- Hits        11804    11801       -3     
- Misses       8764     8769       +5     
- Partials      627      628       +1     

Flag	Coverage Δ
unittests	55.67% <0.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/util/validation/validation.go	82.68% <0.00%> (-1.41%)	⬇️

... and 2 files with indirect coverage changes

[liangyuanpeng]

LGTM, it's uesful, i have cost some time in this point.

[chaunceyjiang]

/cc @RainbowMango PTAL.

[RainbowMango]

/approve
Thanks.
@Poor12 Can you please double-check if the current validation is enough?

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RainbowMango]

I guess release-1.6 also needs this patch, right?

[RainbowMango]

Just opened an issue to track the cherry-pick thing #3744.

[Poor12]

/approve Thanks. @Poor12 Can you please double-check if the current validation is enough?

Although it is not a hot bug, I think it deserves a cherry-pick.