-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:sign image for helm chart #3841
base: master
Are you sure you want to change the base?
feat:sign image for helm chart #3841
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e21201b
to
390c97c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3841 +/- ##
=======================================
Coverage 52.84% 52.84%
=======================================
Files 239 239
Lines 23558 23558
=======================================
Hits 12450 12450
+ Misses 10432 10431 -1
- Partials 676 677 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
@liangyuanpeng sorry for the delay. I'm not sure if I have enough time for this month, busying with KubeCon stuff recently. |
@RainbowMango No worry, this is a low level issue. My talk of karmada for kubecon shanghai is missed and still wish you have fun 😄 |
Oh, what a pity~ |
Signed-off-by: Lan Liang <gcslyp@gmail.com>
8368d8e
to
f3d8587
Compare
Ask @zhzhuang-zju to take a look and help. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
hack/package-helm-chart.sh
tohack/helm-chart-package.sh
for classifysignImage()
to util.sh and renameutil::signImage()
Which issue(s) this PR fixes:
Part2 of #3435
Special notes for your reviewer:
Does this PR introduce a user-facing change?: