Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ut in TestMultiClusterCache watch #3862

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

ikaven1024
Copy link
Member

@ikaven1024 ikaven1024 commented Jul 29, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Refer to #3730 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: yingjinhui <yingjinhui@didiglobal.com>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 29, 2023
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3862 (fda27d9) into master (2526de8) will increase coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3862      +/-   ##
==========================================
+ Coverage   55.17%   55.19%   +0.01%     
==========================================
  Files         227      227              
  Lines       21653    21671      +18     
==========================================
+ Hits        11948    11962      +14     
- Misses       9069     9072       +3     
- Partials      636      637       +1     
Flag Coverage Δ
unittests 55.19% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@ikaven1024
Copy link
Member Author

The behavior of Cacher handling watch requests with empty RV changes. It will fetch objects from underlying storage, instead of local cache.

This change is introduced fron kubernetes/kubernetes#115096

@XiShanYongYe-Chang @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Great thanks! @ikaven1024

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2023
@karmada-bot karmada-bot merged commit 04d2ef1 into karmada-io:master Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants