[1.6] Bump k8s.io dependencies to v0.26.4 #3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/M
liangyuanpeng
force-pushed
the
bump_k8sio_0.26.4
branch
from
cf93068 to
6d0791c
Compare
karmada-bot
added
size/XL
|
Modify as little as possible, maybe just only upgrading the client-go dependency. |
liangyuanpeng
force-pushed
the
bump_k8sio_0.26.4
branch
2 times, most recently
from
03b3d6f to
f44017d
Compare
|
CI Failed for setup env timeout. #7 [3/3] COPY karmada-metrics-adapter /bin/karmada-metrics-adapter
#7 DONE 0.4s
#8 exporting to image
#8 exporting layers
#8 exporting layers 0.9s done
#8 writing image sha256:52bc58a8bd6c55ebefac682ef5be1a5d116e269611d1afc18ef15031c3ef99d0 done
#8 naming to docker.io/karmada/karmada-metrics-adapter:latest done
#8 DONE 1.0s
+ set +x
make: Leaving directory '/home/runner/work/karmada/karmada'
Waiting for the host clusters to be ready...
Waiting for kubeconfig file /home/runner/.kube/karmada.config and clusters karmada-host to be ready...
Error: Timeout waiting for file exist /home/runner/.kube/karmada.config
Error: Process completed with exit code 1. |
liangyuanpeng
force-pushed
the
bump_k8sio_0.26.4
branch
from
f44017d to
8d71bab
Compare
I think we should update all Kubernetes dependencies together, as a bugfix in client-go might not just affect client-go. |
|
May flake test. STEP: Check if clusterRoleBinding(system:test.tt:clusterrolebinding-bzvtm) disappear on member clusters @ 08/10/23 02:49:52.084
<< Timeline
------------------------------
• [FAILED] [430.524 seconds]
[ClusterAffinities] propagation testing when [PropagationPolicy] replica scheduling type is Duplicated schedule with multi clusterAffinity [It] propagate deployment and then update the cluster label
/home/runner/work/karmada/karmada/test/e2e/clusteraffinities_test.go:81
Captured StdOut/StdErr Output >>
I0810 02:42:50.881174 44504 deployment.go:74] Waiting for deployment(karmadatest-fgx2p/deploy-x4vt9) synced on cluster(member1)
I0810 02:42:55.920556 44504 deployment.go:98] Waiting for deployment(karmadatest-fgx2p/deploy-x4vt9) disappears on cluster(member1)
I0810 02:43:00.930797 44504 deployment.go:74] Waiting for deployment(karmadatest-fgx2p/deploy-x4vt9) synced on cluster(member2)
I0810 02:43:00.973052 44504 deployment.go:98] Waiting for deployment(karmadatest-fgx2p/deploy-x4vt9) disappears on cluster(member2)
<< Captured StdOut/StdErr Output
Timeline >>
STEP: Creating PropagationPolicy(karmadatest-fgx2p/deploy-x4vt9) @ 08/10/23 02:42:50.645
STEP: Creating Deployment(karmadatest-fgx2p/deploy-x4vt9) @ 08/10/23 02:42:50.861
[FAILED] in [It] - /home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:110 @ 08/10/23 02:50:00.974
STEP: Removing PropagationPolicy(karmadatest-fgx2p/deploy-x4vt9) @ 08/10/23 02:50:00.974
STEP: Removing Deployment(karmadatest-fgx2p/deploy-x4vt9) @ 08/10/23 02:50:00.996
<< Timeline
[FAILED] Timed out after 420.001s.
Expected
<bool>: false
to equal
<bool>: true
In [It] at: /home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:110 @ 08/10/23 02:50:00.974
Full Stack Trace
github.com/karmada-io/karmada/test/e2e/framework.WaitDeploymentDisappearOnCluster({0x4029f09, 0x7}, {0xc00058b500, 0x11}, {0xc000af5e64, 0xc})
/home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:110 +0x62b
github.com/karmada-io/karmada/test/e2e.glob..func2.1.1.4()
/home/runner/work/karmada/karmada/test/e2e/clusteraffinities_test.go:94 +0x3ff
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
[SynchronizedAfterSuite] [INTERRUPTED] [0.004 seconds]
[SynchronizedAfterSuite]
/home/runner/work/karmada/karmada/test/e2e/suite_test.go:137
[INTERRUPTED] Interrupted by Other Ginkgo Process
In [SynchronizedAfterSuite] at: /home/runner/work/karmada/karmada/test/e2e/suite_test.go:137 @ 08/10/23 02:50:01.119
Full Stack Trace
------------------------------
• [INTERRUPTED] [4.072 seconds]
Resource interpreter webhook testing InterpreterOperation InterpretStatus testing [It] InterpretStatus testing
/home/runner/work/karmada/karmada/test/e2e/resourceinterpreter_test.go:195
Captured StdOut/StdErr Output >>
W0810 02:49:57.106608 44503 warnings.go:70] unknown field "spec.template.metadata.creationTimestamp"
W0810 02:49:57.106638 44503 warnings.go:70] unknown field "spec.template.metadata.labels"
<< Captured StdOut/StdErr Output
Timeline >>
STEP: Creating PropagationPolicy(karmadatest-vbpm8/workload-qnctm) @ 08/10/23 02:49:57.096
STEP: Creating workload(karmadatest-vbpm8/workload-qnctm) @ 08/10/23 02:49:57.102
STEP: Get workload(karmadatest-vbpm8/workload-qnctm) @ 08/10/23 02:49:57.107
[INTERRUPTED] in [It] - /home/runner/work/karmada/karmada/test/e2e/resourceinterpreter_test.go:195 @ 08/10/23 02:50:01.129
STEP: Remove workload(karmadatest-vbpm8/workload-qnctm) @ 08/10/23 02:50:01.131
STEP: Removing PropagationPolicy(karmadatest-vbpm8/workload-qnctm) @ 08/10/23 02:50:01.149
<< Timeline
[INTERRUPTED] Interrupted by Other Ginkgo Process
In [It] at: /home/runner/work/karmada/karmada/test/e2e/resourceinterpreter_test.go:195 @ 08/10/23 02:50:01.129
Full Stack Trace
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
[SynchronizedAfterSuite] PASSED [0.120 seconds]
[SynchronizedAfterSuite]
/home/runner/work/karmada/karmada/test/e2e/suite_test.go:137
------------------------------
Summarizing 3 Failures:
[FAIL] [ClusterAffinities] propagation testing when [PropagationPolicy] replica scheduling type is Duplicated schedule with multi clusterAffinity [It] propagate deployment and then update the cluster label
/home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:110
[INTERRUPTED] [SynchronizedAfterSuite]
/home/runner/work/karmada/karmada/test/e2e/suite_test.go:137
[INTERRUPTED] Resource interpreter webhook testing InterpreterOperation InterpretStatus testing [It] InterpretStatus testing
/home/runner/work/karmada/karmada/test/e2e/resourceinterpreter_test.go:195
Ran 50 of 138 Specs in 492.684 seconds
FAIL! - Interrupted by Other Ginkgo Process -- 48 Passed | 2 Failed | 0 Pending | 88 Skipped
Ginkgo ran 1 suite in 11m34.849668747s
Test Suite Failed
Collect logs to /home/runner/work/karmada/karmada/karmada-e2e-logs/v1.25.0/... |
Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
force-pushed
the
bump_k8sio_0.26.4
branch
from
8d71bab to
ac2e234
Compare
ohh, sorry about that, i just force push to rerun CI. |
|
No worries, it's quicker than the admin to manually retrigger it :) . Thanks for your analysis. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Clients using client-go v0.26.0 - v0.26.3 can panic under the following conditions
Ref: kubernetes/kubernetes#119840
Related:
For karmada, The component that may cause an impact is:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: