-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed sigs.k8s.io/cluster-api v1.5.0-rc.0 to v1.5.0 #3934
Conversation
Looks good, but you might need to sign the DCO:https://github.com/karmada-io/karmada/pull/3934/checks?check_run_id=15816626820 |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3934 +/- ##
=======================================
Coverage 54.70% 54.70%
=======================================
Files 229 229
Lines 22074 22074
=======================================
Hits 12076 12076
Misses 9352 9352
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Parth Nanda <parthnanda002@gmail.com>
Oh sorry! I forgot to do that, I signed it off now. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangyuanpeng, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates the cluster-api version
Which issue(s) this PR fixes:
Fixes #3932
Special notes for your reviewer:
Does this PR introduce a user-facing change?: