-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve overridemanager test #3943
improve overridemanager test #3943
Conversation
Welcome @vie-serendipity! It looks like this is your first PR to karmada-io/karmada 🎉 |
Hi @vie-serendipity welcome to karmada! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot.
The updated context LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks @vie-serendipity
You might need to sign the commit as per: #3943 (comment)
/assign @XiShanYongYe-Chang
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3943 +/- ##
==========================================
- Coverage 54.71% 54.69% -0.02%
==========================================
Files 229 229
Lines 22074 22074
==========================================
- Hits 12077 12074 -3
- Misses 9351 9354 +3
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: vie-serendipity <2733147505@qq.com>
7aed433
to
ec6a83c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind flake
What this PR does / why we need it:
Actually, this doesn't trigger any bugs, but it ought to be of the form `"{{string}}"`. Otherwise there will be no double quotes when converting to a string and cause a marshal error in encoding/json. Just in case developers want to add a unit test on plaintext overrider later, I create this pr.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: