-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy connect get cluster impersonator secret use secretLister #3947
Proxy connect get cluster impersonator secret use secretLister #3947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, and you will add relevant test cases later, right?
Thanks~ The UT run failed, can you help take a look? |
a9a2277
to
b316fbd
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3947 +/- ##
==========================================
- Coverage 54.85% 54.71% -0.14%
==========================================
Files 229 229
Lines 21927 22079 +152
==========================================
+ Hits 12027 12080 +53
- Misses 9261 9353 +92
- Partials 639 646 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b316fbd
to
8e7d11a
Compare
I added UT @XiShanYongYe-Chang @zishen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
8e7d11a
to
c30e6e6
Compare
Thanks~ |
@XiShanYongYe-Chang Are you waiting for me to take a look? |
Hi @RainbowMango we need you to approve the merge request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
When using the proxy function provided by karmada-aggregated-apiserver to access member cluster resources. The current implementation needs to obtain the impersonator secret corresponding to the member cluster in real time each time.
In large-scale scenarios, the number of requests to karmada-apiserver will increase, and I think cached queries should be used
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: