-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the execute permission from the directory #3992
Conversation
CI is failing:
|
yea, Directory requires execute permission, otherwise files cannot be created. |
runner@fv-az454-559:~$ pwd
/home/runner
runner@fv-az454-559:~$ mkdir /home/runner/karmada
runner@fv-az454-559:~$ chmod -R 640 /home/runner/karmada
runner@fv-az454-559:~$ mkdir /home/runner/karmada/pki
mkdir: cannot create directory ‘/home/runner/karmada/pki’: Permission denied As you see, if you chmod more example as follows: runner@fv-az454-559:~$ mkdir /home/runner/karmada
runner@fv-az454-559:~$ chmod -R 700 /home/runner/karmada
runner@fv-az454-559:~$ mkdir /home/runner/karmada/pki
runner@fv-az454-559:~$ chmod -R 700 /home/runner/karmada/pki
runner@fv-az454-559:~$ touch /home/runner/karmada/pki/xx.txt
runner@fv-az454-559:~$ ls /home/runner/karmada/pki/xx.txt
/home/runner/karmada/pki/xx.txt runner@fv-az454-559:~$ mkdir /home/runner/karmada
runner@fv-az454-559:~$ chmod -R 700 /home/runner/karmada
runner@fv-az454-559:~$ mkdir /home/runner/karmada/pki
runner@fv-az454-559:~$ chmod -R 640 /home/runner/karmada/pki
runner@fv-az454-559:~$ touch /home/runner/karmada/pki/xx.txt
touch: cannot touch '/home/runner/karmada/pki/xx.txt': Permission denied
|
Signed-off-by: Tanggui Bian <softwarebtg@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango, vincentgoat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Reduce permissions for directories created by karmada itself.
From 755 to 700. Prevent unauthorized users from modifying content.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@RainbowMango @whitewindmills @XiShanYongYe-Chang