Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4085: fix fhpa controller panic when SelectPolicy is nil #4104

Conversation

jwcesign
Copy link
Member

@jwcesign jwcesign commented Oct 7, 2023

Cherry pick of #4085 on release-1.6.
#4085: fix fhpa controller panic when SelectPolicy is nil
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fix panic when FederatedHPA's SelectPolicy is nil and FederatedHPA webhook is disabled.

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e1eb417) 54.35% compared to head (aba9cdc) 54.34%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.6    #4104      +/-   ##
===============================================
- Coverage        54.35%   54.34%   -0.02%     
===============================================
  Files              223      223              
  Lines            21295    21295              
===============================================
- Hits             11575    11572       -3     
- Misses            9096     9098       +2     
- Partials           624      625       +1     
Flag Coverage Δ
unittests 54.34% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwcesign jwcesign force-pushed the automated-cherry-pick-of-#4085-upstream-release-1.6 branch 2 times, most recently from 72dbf64 to aba9cdc Compare October 9, 2023 12:17
Signed-off-by: watermeion <watermeion@hotmail.com>
@jwcesign jwcesign force-pushed the automated-cherry-pick-of-#4085-upstream-release-1.6 branch from aba9cdc to c0a123c Compare October 11, 2023 07:01
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@karmada-bot karmada-bot merged commit eaf91e0 into karmada-io:release-1.6 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants