-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnqueueAffectedBindings and enqueueAffectedCRBs add schedulerNameFilter #4139
EnqueueAffectedBindings and enqueueAffectedCRBs add schedulerNameFilter #4139
Conversation
Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4139 +/- ##
==========================================
- Coverage 53.46% 53.44% -0.03%
==========================================
Files 234 234
Lines 23279 23287 +8
==========================================
- Hits 12447 12445 -2
- Misses 10150 10160 +10
Partials 682 682
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
Nice works!
/assign @XiShanYongYe-Chang |
@yanfeng1992, just out of curiosity, how did you notice it? |
Karmada's scheduler currently cannot support concurrency. We are trying to use a new scheduler that can support concurrency in large-scale scenarios. Specifically used to handle some resources that can be scheduled concurrently, such as some resources spread through the non replica duplicate pp, cpp. This problem was discovered because we have two schedulers @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot~
/approve
Can you help cherry-pick it to the previous branch?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How about update the release note to: |
ok done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…4139-upstream-release-1.7 Automated cherry pick of #4139: enqueueAffectedBindings and enqueueAffectedCRBs add
…4139-upstream-release-1.6 Automated cherry pick of #4139: enqueueAffectedBindings and enqueueAffectedCRBs add
What type of PR is this?
/kind bug
What this PR does / why we need it:
enqueueAffectedBindings and enqueueAffectedCRBs add schedulerNameFilter
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: