Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnqueueAffectedBindings and enqueueAffectedCRBs add schedulerNameFilter #4139

Merged

Conversation

yanfeng1992
Copy link
Member

@yanfeng1992 yanfeng1992 commented Oct 17, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

enqueueAffectedBindings and enqueueAffectedCRBs add schedulerNameFilter

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-scheduler`: Fixed an issue that the scheduler does not ignore RB/CRB by scheduler name during enqueuing.

Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2023
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 17, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (3eba2a9) 53.46% compared to head (27971f4) 53.44%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4139      +/-   ##
==========================================
- Coverage   53.46%   53.44%   -0.03%     
==========================================
  Files         234      234              
  Lines       23279    23287       +8     
==========================================
- Hits        12447    12445       -2     
- Misses      10150    10160      +10     
  Partials      682      682              
Flag Coverage Δ
unittests 53.44% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/scheduler/event_handler.go 21.72% <0.00%> (-0.74%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanfeng1992 yanfeng1992 changed the title enqueueAffectedBindings and enqueueAffectedCRBs add schedulerNameFilter EnqueueAffectedBindings and enqueueAffectedCRBs add schedulerNameFilter Oct 17, 2023
Copy link
Member

@jwcesign jwcesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Nice works!

@yanfeng1992
Copy link
Member Author

/assign @XiShanYongYe-Chang

@RainbowMango
Copy link
Member

@yanfeng1992, just out of curiosity, how did you notice it?

@yanfeng1992
Copy link
Member Author

just out of curiosity, how did you notice it?

Karmada's scheduler currently cannot support concurrency. We are trying to use a new scheduler that can support concurrency in large-scale scenarios. Specifically used to handle some resources that can be scheduled concurrently, such as some resources spread through the non replica duplicate pp, cpp. This problem was discovered because we have two schedulers @RainbowMango

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~
/approve

Can you help cherry-pick it to the previous branch?

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@XiShanYongYe-Chang
Copy link
Member

How about update the release note to:
karmada-scheduler: add schedulerName filter when enqueue affected RB/CRB

@yanfeng1992
Copy link
Member Author

How about update the release note to: karmada-scheduler: add schedulerName filter when enqueue affected RB/CRB

ok done

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@karmada-bot karmada-bot merged commit e2e33a5 into karmada-io:master Oct 18, 2023
karmada-bot added a commit that referenced this pull request Oct 19, 2023
…4139-upstream-release-1.7

Automated cherry pick of #4139: enqueueAffectedBindings and enqueueAffectedCRBs add
karmada-bot added a commit that referenced this pull request Oct 19, 2023
…4139-upstream-release-1.6

Automated cherry pick of #4139: enqueueAffectedBindings and enqueueAffectedCRBs add
@yanfeng1992 yanfeng1992 deleted the fix-scheduler-eventfilter branch April 2, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants