-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.5] Automated cherry pick of #4160: Prune job label for kubernetes 1.27,prefix with #4264
[1.5] Automated cherry pick of #4160: Prune job label for kubernetes 1.27,prefix with #4264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we can not cherry-pick directly.
Yes, since release-1.5 is referencing the Kubernetes v1.26, it can not refer constants introduced in Kubernetes v1.27. I think we can hardcode the label names here. |
Signed-off-by: Lan Liang <gcslyp@gmail.com> Co-authored-by: Hongcai Ren <renhongcai@huawei.com>
ebf6dee
to
44d59f8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-1.5 #4264 +/- ##
============================================
Coverage 49.14% 49.14%
============================================
Files 203 203
Lines 18530 18530
============================================
Hits 9106 9106
Misses 8926 8926
Partials 498 498
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #4160 on release-1.5.
#4160: Prune job label for kubernetes 1.27,prefix with
For details on the cherry pick process, see the cherry pick requests page.