Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support karmadactl config current-context #4299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/king feature

What this PR does / why we need it:
Support command karmadactl config current-context to view the current-context
Which issue(s) this PR fixes:
Parts of #4297

Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:

add command ```karmadactl config current-context``` to view the current-context

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign chaunceyjiang after the PR has been reviewed.
You can assign the PR to them by writing /assign @chaunceyjiang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fe9dff) 52.78% compared to head (2607653) 52.78%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4299   +/-   ##
=======================================
  Coverage   52.78%   52.78%           
=======================================
  Files         240      240           
  Lines       23624    23624           
=======================================
+ Hits        12470    12471    +1     
+ Misses      10474    10473    -1     
  Partials      680      680           
Flag Coverage Δ
unittests 52.78% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zhzhuang-zju <m17799853869@163.com>
@zhzhuang-zju zhzhuang-zju force-pushed the ctl-config-currentcontext branch from fa55cad to 2607653 Compare November 22, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants