Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make metrics-adapter chart installation optional #4375

Merged

Conversation

yizhang-zen
Copy link
Contributor

@yizhang-zen yizhang-zen commented Dec 6, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
With this change in v1.8: #4303, karmada-metrics-adapter is part of the helm chart when install karmada.

This change is to make karmada-metrics-adapter installation in components with host when set.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`Helm Chart`: Make `karmada-metrics-adapter` installation optional with host mode.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 6, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2023
Signed-off-by: yizhang-zen <yizhang@zendesk.com>
@yizhang-zen yizhang-zen force-pushed the yizhang/metrics-adapter-optional branch from 528f0ab to 7209521 Compare December 6, 2023 00:33
@RainbowMango
Copy link
Member

cc @jwcesign @chaosi-zju for help

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1cafe7f) 51.87% compared to head (7209521) 51.87%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4375      +/-   ##
==========================================
- Coverage   51.87%   51.87%   -0.01%     
==========================================
  Files         243      243              
  Lines       24114    24114              
==========================================
- Hits        12510    12508       -2     
- Misses      10922    10923       +1     
- Partials      682      683       +1     
Flag Coverage Δ
unittests 51.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
Copy link
Member

@jwcesign jwcesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

By the way, I think this is not a bug, it's an enhancement

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
@karmada-bot karmada-bot merged commit c784ef1 into karmada-io:master Dec 6, 2023
13 checks passed
@yizhang-zen yizhang-zen deleted the yizhang/metrics-adapter-optional branch December 6, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants