-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make metrics-adapter chart installation optional #4375
make metrics-adapter chart installation optional #4375
Conversation
Signed-off-by: yizhang-zen <yizhang@zendesk.com>
528f0ab
to
7209521
Compare
cc @jwcesign @chaosi-zju for help |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4375 +/- ##
==========================================
- Coverage 51.87% 51.87% -0.01%
==========================================
Files 243 243
Lines 24114 24114
==========================================
- Hits 12510 12508 -2
- Misses 10922 10923 +1
- Partials 682 683 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
By the way, I think this is not a bug, it's an enhancement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
With this change in v1.8: #4303, karmada-metrics-adapter is part of the helm chart when install karmada.
This change is to make karmada-metrics-adapter installation in components with host when set.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: