Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Embedded metadata field for workload CRD #4508

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

chengleqi
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:
add Embedded metadata field for workload CRD

Which issue(s) this PR fixes:
Fixes #4507

Special notes for your reviewer:
none
Does this PR introduce a user-facing change?:

NONE

Signed-off-by: chengleqi <chengleqi5g@hotmail.com>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 3, 2024
@karmada-bot
Copy link
Collaborator

Welcome @chengleqi! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 3, 2024
@RainbowMango
Copy link
Member

/assign @zhzhuang-zju @XiShanYongYe-Chang

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2deee5d) 51.86% compared to head (b268b49) 51.87%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4508   +/-   ##
=======================================
  Coverage   51.86%   51.87%           
=======================================
  Files         243      243           
  Lines       24181    24181           
=======================================
+ Hits        12542    12544    +2     
+ Misses      10957    10956    -1     
+ Partials      682      681    -1     
Flag Coverage Δ
unittests 51.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

@chengleqi Thanks~
let me take a look.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~
/lgtm

The CRD involved in this issue is a Workload CRD in the example. I believe that this patch does not need to be synchronized with previous versions.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2024
@karmada-bot karmada-bot merged commit 845ee83 into karmada-io:master Jan 4, 2024
12 checks passed
@chengleqi chengleqi deleted the fix-crd branch January 4, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot deploy workload CRD using Resource Interpreter
6 participants