-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add Embedded metadata field for workload CRD #4508
Conversation
Signed-off-by: chengleqi <chengleqi5g@hotmail.com>
Welcome @chengleqi! It looks like this is your first PR to karmada-io/karmada 🎉 |
/assign @zhzhuang-zju @XiShanYongYe-Chang |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4508 +/- ##
=======================================
Coverage 51.86% 51.87%
=======================================
Files 243 243
Lines 24181 24181
=======================================
+ Hits 12542 12544 +2
+ Misses 10957 10956 -1
+ Partials 682 681 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@chengleqi Thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot~
/lgtm
The CRD involved in this issue is a Workload CRD in the example. I believe that this patch does not need to be synchronized with previous versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
add Embedded metadata field for workload CRD
Which issue(s) this PR fixes:
Fixes #4507
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: