Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4554: search add check member cluster api enable #4590

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Jan 27, 2024

Cherry pick of #4554 on release-1.6.
#4554: search add check member cluster api enable
For details on the cherry pick process, see the cherry pick requests page.

`karmada-search`: Add the logic of checking whether the resource API to be retrieved is installed in the cluster.

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4a69018) 54.31% compared to head (25c1a06) 54.32%.

Files Patch % Lines
pkg/search/proxy/controller.go 14.28% 4 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.6    #4590   +/-   ##
============================================
  Coverage        54.31%   54.32%           
============================================
  Files              223      223           
  Lines            21311    21317    +6     
============================================
+ Hits             11576    11580    +4     
  Misses            9110     9110           
- Partials           625      627    +2     
Flag Coverage Δ
unittests 54.32% <14.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#4554-upstream-release-1.6 branch from 68791b8 to 1bf27aa Compare January 27, 2024 09:58
Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#4554-upstream-release-1.6 branch from 1bf27aa to 25c1a06 Compare January 29, 2024 02:56
@XiShanYongYe-Chang
Copy link
Member Author

Hi @ikaven1024, can you help approve this cherry-pick?
/cc @ikaven1024

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@karmada-bot karmada-bot merged commit 59dbdfb into karmada-io:release-1.6 Jan 29, 2024
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the automated-cherry-pick-of-#4554-upstream-release-1.6 branch February 26, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants