-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup the deprecated package of k8s.io/utils/pointer. #4719
Cleanup the deprecated package of k8s.io/utils/pointer. #4719
Conversation
pkg/resourceinterpreter/customized/declarative/luavm/lua_test.go
Outdated
Show resolved
Hide resolved
Hi @liangyuanpeng the CI is failed. |
3ea590d
to
26f0a47
Compare
#3 ERROR: failed to do request: Head "https://registry-1.docker.io/v2/library/alpine/manifests/3.19.1": net/http: TLS handshake timeout
------
> [internal] load metadata for docker.io/library/alpine:3.19.1:
------
Dockerfile:15
--------------------
13 | # limitations under the License.
14 |
15 | >>> FROM alpine:3.19.1
16 |
17 | ARG BINARY
--------------------
ERROR: failed to solve: alpine:3.19.1: failed to do request: Head "https://registry-1.docker.io/v2/library/alpine/manifests/3.19.1": net/http: TLS handshake timeout
make: *** [Makefile:58: image-karmada-operator] Error 1
make: Leaving directory '/home/runner/work/karmada/karmada'
Error: Process completed with exit code 2. CI |
aaef270
to
b7b583a
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4719 +/- ##
=======================================
Coverage 53.32% 53.33%
=======================================
Files 252 252
Lines 20539 20539
=======================================
+ Hits 10953 10954 +1
+ Misses 8861 8860 -1
Partials 725 725
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e3279a4
to
9968d1f
Compare
/hold |
28fd57b
to
6534ffb
Compare
891c309
to
dc741e4
Compare
/hold cancel |
@liangyuanpeng In addition, we are waiting for kubernetes-sigs/custom-metrics-apiserver#167 to bump Kuberentes dependencies v1.29. |
Thank you for your detailed explanation, it's make sense for me. |
Hi @liangyuanpeng We can get back on this now as the Kubernetes dependencies now is v1.29.4.
We don't need to bump the version, right? We can cleanup the usage of deprecated packages though. |
I will update it ASAP. |
Kindly ping @liangyuanpeng
|
dc741e4
to
7a914c1
Compare
7a914c1
to
5ddb281
Compare
…nce a pointer. The new k8s.io/utils/ptr package provides generic wrapper functions, which can be used instead of type-specific pointer wrapper functions. This replaces the latter with the former, and migrates other uses of the deprecated pointer package to ptr in affacted files. See kubernetes/utils#283 for details. Signed-off-by: Lan Liang <gcslyp@gmail.com>
5ddb281
to
ed0f26c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
1. Bump k8s.io/utils to 20240102154912-e7106e64919e2. cleanup the deprecated package of pointer, use
k8s.io/utils/ptr
instead.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: