Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4751: fix wrong annotation marks on resource #4770

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Mar 28, 2024

Cherry pick of #4751 on release-1.7.
#4751: fix wrong annotation marks on resource
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed incorrect annotation markup when policy preemption occurs.

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2024
Signed-off-by: changzhen <changzhen5@huawei.com>
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#4751-upstream-release-1.7 branch from 94a190a to 795ef15 Compare March 28, 2024 07:30
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.86%. Comparing base (7d8674b) to head (795ef15).

Files Patch % Lines
pkg/detector/detector.go 0.00% 1 Missing ⚠️
pkg/util/helper/work.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.7    #4770      +/-   ##
===============================================
- Coverage        53.87%   53.86%   -0.01%     
===============================================
  Files              231      231              
  Lines            22964    22964              
===============================================
- Hits             12371    12370       -1     
- Misses            9923     9924       +1     
  Partials           670      670              
Flag Coverage Δ
unittests 53.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@karmada-bot karmada-bot merged commit 5ce59e7 into karmada-io:release-1.7 Mar 28, 2024
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the automated-cherry-pick-of-#4751-upstream-release-1.7 branch April 18, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants