Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combined case 3 in the lazy activation policy tests #5033

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

Affan-7
Copy link
Contributor

@Affan-7 Affan-7 commented Jun 9, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
For better test coverage.

Which issue(s) this PR fixes:
Part of the #4607

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 9, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.23%. Comparing base (049ddc6) to head (8f1b112).
Report is 14 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5033       +/-   ##
===========================================
- Coverage   53.33%   28.23%   -25.11%     
===========================================
  Files         253      632      +379     
  Lines       20558    43435    +22877     
===========================================
+ Hits        10965    12262     +1297     
- Misses       8867    30279    +21412     
- Partials      726      894      +168     
Flag Coverage Δ
unittests 28.23% <ø> (-25.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

/assign @chaosi-zju

Copy link
Member

@chaosi-zju chaosi-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Affan-7, thank you for your work~

test/e2e/lazy_activation_policy_test.go Outdated Show resolved Hide resolved
test/e2e/lazy_activation_policy_test.go Outdated Show resolved Hide resolved
Signed-off-by: Mohammed Affan <mohammed.affan.727@gmail.com>
@chaosi-zju
Copy link
Member

/lgtm

CC @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
@RainbowMango
Copy link
Member

Thanks @Affan-7, Hope you are doing fine.
/assign @XiShanYongYe-Chang

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Affan-7
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@karmada-bot karmada-bot merged commit 86d1ac7 into karmada-io:master Jun 14, 2024
12 checks passed
@Affan-7 Affan-7 deleted the e2e-test branch June 14, 2024 19:42
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants