-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add combined case 3 in the lazy activation policy tests #5033
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5033 +/- ##
===========================================
- Coverage 53.33% 28.23% -25.11%
===========================================
Files 253 632 +379
Lines 20558 43435 +22877
===========================================
+ Hits 10965 12262 +1297
- Misses 8867 30279 +21412
- Partials 726 894 +168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign @chaosi-zju |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Affan-7, thank you for your work~
33e19a3
to
91a8429
Compare
Signed-off-by: Mohammed Affan <mohammed.affan.727@gmail.com>
/lgtm |
Thanks @Affan-7, Hope you are doing fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Affan-7
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
For better test coverage.
Which issue(s) this PR fixes:
Part of the #4607
Does this PR introduce a user-facing change?: