Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add proposal of enhancing karmadactl #5245

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

hulizhe
Copy link
Contributor

@hulizhe hulizhe commented Jul 24, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Enhance karmadactl operation and maintenance experience

Which issue(s) this PR fixes:
Parts of #5248

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 24, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 24, 2024
@hulizhe hulizhe force-pushed the karmadactlproposal branch from 698a465 to 89039a9 Compare July 24, 2024 09:33
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.02%. Comparing base (5e3e5ad) to head (dcc0ad0).
Report is 131 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5245      +/-   ##
==========================================
+ Coverage   28.25%   29.02%   +0.76%     
==========================================
  Files         632      632              
  Lines       43739    43862     +123     
==========================================
+ Hits        12360    12729     +369     
+ Misses      30478    30218     -260     
- Partials      901      915      +14     
Flag Coverage Δ
unittests 29.02% <ø> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

/retest

@hulizhe hulizhe force-pushed the karmadactlproposal branch 2 times, most recently from 3735913 to 70471e0 Compare July 30, 2024 03:02
@hulizhe hulizhe force-pushed the karmadactlproposal branch from 70471e0 to f22a970 Compare August 2, 2024 03:40
@XiShanYongYe-Chang
Copy link
Member

/assign
/assign @chaunceyjiang
/retest

@chaunceyjiang
Copy link
Member

/assign

@hulizhe
Copy link
Contributor Author

hulizhe commented Aug 12, 2024

Signed-off-by: hulizhe <pompeii.hu@gmail.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Generally looks good to me.
But we are open to make changes during the implementation, such as minor flags updates.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@zhzhuang-zju
Copy link
Contributor

/retest

@karmada-bot karmada-bot merged commit 0fb9879 into karmada-io:master Aug 14, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants