-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add proposal of enhancing karmadactl #5245
Conversation
698a465
to
89039a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5245 +/- ##
==========================================
+ Coverage 28.25% 29.02% +0.76%
==========================================
Files 632 632
Lines 43739 43862 +123
==========================================
+ Hits 12360 12729 +369
+ Misses 30478 30218 -260
- Partials 901 915 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
3735913
to
70471e0
Compare
70471e0
to
f22a970
Compare
/assign |
/assign |
docs/proposals/karmadactl/enhance_karmadactl_maintenance_experience.md
Outdated
Show resolved
Hide resolved
docs/proposals/karmadactl/enhance_karmadactl_maintenance_experience.md
Outdated
Show resolved
Hide resolved
kindly ping @XiShanYongYe-Chang @chaunceyjiang @RainbowMango @zhzhuang-zju |
docs/proposals/karmadactl/enhance_karmadactl_maintenance_experience.md
Outdated
Show resolved
Hide resolved
docs/proposals/karmadactl/enhance_karmadactl_maintenance_experience.md
Outdated
Show resolved
Hide resolved
docs/proposals/karmadactl/enhance_karmadactl_maintenance_experience.md
Outdated
Show resolved
Hide resolved
docs/proposals/karmadactl/enhance_karmadactl_maintenance_experience.md
Outdated
Show resolved
Hide resolved
docs/proposals/karmadactl/enhance_karmadactl_maintenance_experience.md
Outdated
Show resolved
Hide resolved
docs/proposals/karmadactl/enhance_karmadactl_maintenance_experience.md
Outdated
Show resolved
Hide resolved
docs/proposals/karmadactl/enhance_karmadactl_maintenance_experience.md
Outdated
Show resolved
Hide resolved
docs/proposals/karmadactl/enhance_karmadactl_maintenance_experience.md
Outdated
Show resolved
Hide resolved
Signed-off-by: hulizhe <pompeii.hu@gmail.com>
f22a970
to
dcc0ad0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Generally looks good to me.
But we are open to make changes during the implementation, such as minor flags updates.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Enhance karmadactl operation and maintenance experience
Which issue(s) this PR fixes:
Parts of #5248
Special notes for your reviewer:
Does this PR introduce a user-facing change?: