-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 100% test coverage for matcher, shadow, and names.go in pkg/util #5339
Add 100% test coverage for matcher, shadow, and names.go in pkg/util #5339
Conversation
Signed-off-by: Nishant Bansal <nishant.bansal.mec21@iitbhu.ac.in>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5339 +/- ##
==========================================
+ Coverage 28.53% 28.54% +0.01%
==========================================
Files 632 632
Lines 43856 43856
==========================================
+ Hits 12515 12520 +5
+ Misses 30443 30439 -4
+ Partials 898 897 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey @XiShanYongYe-Chang, PTAL, and provide your valuable feedback. |
Hi @XiShanYongYe-Chang, just pinging in case this PR was missed. |
Thanks @NishantBansal2003 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/kind failing-test
What this PR does / why we need it:
The test case coverage for interpreter/matcher.go, overridemanager/shadow.go and names/names.go has been increased to 100%.
Which issue(s) this PR fixes:
Ref #5235
Special notes for your reviewer:
To verify the changes in the pkg/util directory run the following commands:
Does this PR introduce a user-facing change?: