Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit test cluster_condition coverage : 100% #5343

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

yashpandey06
Copy link

/kind failing-test
/kind feature

PR Title: Enhance Test Coverage for Status Change in thresholdAdjustedReadyCondition

###Fixes #5337

Description:

  • Added test cases to cover scenarios where the readyCondition status changes in the thresholdAdjustedReadyCondition method.
  • Focused on ensuring that the thresholdStartTime is updated correctly when the condition changes and that the old status is retained until the threshold is exceeded.

@karmada-bot karmada-bot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 9, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 9, 2024
@yashpandey06
Copy link
Author

@xiaoloongfang help review this pr

@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 9, 2024
@yashpandey06 yashpandey06 reopened this Aug 9, 2024
@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.74%. Comparing base (034b5d4) to head (4d49f36).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5343      +/-   ##
==========================================
+ Coverage   28.72%   28.74%   +0.01%     
==========================================
  Files         632      632              
  Lines       43862    43862              
==========================================
+ Hits        12600    12608       +8     
+ Misses      30352    30346       -6     
+ Partials      910      908       -2     
Flag Coverage Δ
unittests 28.74% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashpandey06
Copy link
Author

/kind failing-test /kind feature

PR Title: Enhance Test Coverage for Status Change in thresholdAdjustedReadyCondition

Fixes #5235

Description:

  • Added test cases to cover scenarios where the readyCondition status changes in the thresholdAdjustedReadyCondition method.
  • Focused on ensuring that the thresholdStartTime is updated correctly when the condition changes and that the old status is retained until the threshold is exceeded.

@anujagrawal699
Copy link
Contributor

@yashpandey06 Try running go fmt in the package directory before committing.

@yashpandey06
Copy link
Author

@yashpandey06 Try running go fmt in the package directory before committing.

okay trying

@yashpandey06
Copy link
Author

@XiShanYongYe-Chang please help review this pr

@XiShanYongYe-Chang
Copy link
Member

Thanks @yashpandey06
/assign

@XiShanYongYe-Chang
Copy link
Member

Hi @yashpandey06 can you help squash the commits into one?

@yashpandey06
Copy link
Author

Hi @yashpandey06 can you help squash the commits into one?

Sure looking into it

Signed-off-by: Yash Pandey <yash.pandey@agoda.com>

Signed-off-by: Yash Pandey <yash.pandey@agoda.com>
@yashpandey06
Copy link
Author

@XiShanYongYe-Chang Here you go , the commits have been squashed .

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@karmada-bot karmada-bot merged commit 91e1733 into karmada-io:master Aug 13, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Coverage of files in pkg/controllers/status/
6 participants