-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit test cluster_condition coverage : 100% #5343
Conversation
@xiaoloongfang help review this pr |
b57eb17
to
37488bd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5343 +/- ##
==========================================
+ Coverage 28.72% 28.74% +0.01%
==========================================
Files 632 632
Lines 43862 43862
==========================================
+ Hits 12600 12608 +8
+ Misses 30352 30346 -6
+ Partials 910 908 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@yashpandey06 Try running |
okay trying |
@XiShanYongYe-Chang please help review this pr |
Thanks @yashpandey06 |
Hi @yashpandey06 can you help squash the commits into one? |
Sure looking into it |
Signed-off-by: Yash Pandey <yash.pandey@agoda.com> Signed-off-by: Yash Pandey <yash.pandey@agoda.com>
2582ada
to
4d49f36
Compare
@XiShanYongYe-Chang Here you go , the commits have been squashed . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind failing-test
/kind feature
PR Title: Enhance Test Coverage for Status Change in
thresholdAdjustedReadyCondition
###Fixes #5337
Description:
readyCondition
status changes in thethresholdAdjustedReadyCondition
method.thresholdStartTime
is updated correctly when the condition changes and that the old status is retained until the threshold is exceeded.