-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage of pkg/descheduler #5364
Improve test coverage of pkg/descheduler #5364
Conversation
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5364 +/- ##
==========================================
+ Coverage 28.49% 29.28% +0.78%
==========================================
Files 632 632
Lines 43856 43862 +6
==========================================
+ Hits 12497 12844 +347
+ Misses 30455 30089 -366
- Partials 904 929 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
/assign |
@XiShanYongYe-Chang CI Workflow? |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anujagrawal699
Good job!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry, my bad, I forgot to ask you to help squash the commits into one before merging the code. |
I won't be able to squash it after merging? Also, i forgot to mention this PR increased test coverage of project by 0.79%. |
Yes, it can't be compressed anymore after the merge. |
I'll keep that in mind from next PR's. |
Description:
This PR enhances the test coverage for the pkg/descheduler package by adding a new test file pkg/descheduler/core/helper_test.go and improving test coverage of all test files in pkg/descheduler.
Changes:
What type of PR is this?
/kind failing-test
/kind feature
What this PR does / why we need it:
Enhances the functionality of the pkg/descheduler package by improving the robustness of event handling and connection management.
Which issue(s) this PR fixes:
Fixes a part of #5235
Does this PR introduce a user-facing change?: