Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for snapshot in pkg/util/lifted/scheduler/cache #5424

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yashpandey06
Copy link

What type of PR is this?

/kind feature

Description:

This PR adds unit tests for the Snapshot functionality in the cache package.

Key Changes:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 26, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.90%. Comparing base (2537912) to head (ae26bfe).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5424      +/-   ##
==========================================
- Coverage   31.05%   30.90%   -0.16%     
==========================================
  Files         639      639              
  Lines       44313    44313              
==========================================
- Hits        13763    13696      -67     
- Misses      29556    29642      +86     
+ Partials      994      975      -19     
Flag Coverage Δ
unittests 30.90% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

/assign

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xishanyongye-chang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Yash Pandey <yash.pandey@agoda.com>
@yashpandey06 yashpandey06 force-pushed the pkg/util/lifted/scheduler/cache-2 branch from fcba169 to ae26bfe Compare August 27, 2024 05:34
@yashpandey06
Copy link
Author

@XiShanYongYe-Chang please help review this pr , i have already fixed the headers data

Comment on lines +17 to +19
// This code is directly lifted from the Kubernetes codebase in order to avoid relying on the k8s.io/kubernetes package.
// For reference:
// https://github.com/kubernetes/kubernetes/blob/release-1.26/pkg/scheduler/internal/cache/snapshot.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yashpandey06 Is the following test code copied directly from this file? I looked at it and it doesn't seem to be directly copied. You can copy the test functions from the https://github.com/kubernetes/kubernetes/blob/release-1.26/pkg/scheduler/internal/cache/snapshot_test.go file without having to add the test code yourself.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review , I am working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants