-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for federatedhpa controller #5528
Added tests for federatedhpa controller #5528
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5528 +/- ##
==========================================
+ Coverage 32.45% 33.70% +1.25%
==========================================
Files 643 643
Lines 44497 44497
==========================================
+ Hits 14440 14999 +559
+ Misses 28962 28355 -607
- Partials 1095 1143 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com> Added tests for federatedhpa controller Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
7b65e97
to
337f787
Compare
@XiShanYongYe-Chang Could you please trigger a retest? |
You can enter this amount command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove-kind documentation |
@XiShanYongYe-Chang Do a test file for pkg/controllers/federatedhpa/monitor/metrics.go and pkg/controllers/federatedhpa/monitor/monitor.go needed? |
You can try it. I'll see how it works. |
Description:
This PR introduces the first set of comprehensive unit tests for the Federated Horizontal Pod Autoscaler (FederatedHPA) controller and its associated components. Due to the extensive nature of the test additions, i'll try to split the test additions into 2 PR's.
Additions:
Test Coverage Improvements:
federatedhpa_controller_test.go: 0% to 41.2% (More tests will be added in the future PR)
client_test.go: 0% to 92.9%
replica_calculator_test.go: 0% to 85.7%
types_test.go: 0% t 100%
What type of PR is this?
/kind documentation
/kind failing-test
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: