Added tests for hpascaletargetmarker controller #5553
Conversation
karmada-bot
added
the
kind/failing-test
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/XL
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5553 +/- ##
==========================================
- Coverage 34.14% 34.13% -0.01%
==========================================
Files 643 645 +2
Lines 44524 44857 +333
==========================================
+ Hits 15203 15313 +110
- Misses 28165 28379 +214
- Partials 1156 1165 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks~ |
There was a problem hiding this comment.
LGTM
Ask code owner @chaosi-zju to help take a review.
/cc @chaosi-zju
| }) | ||
| } | ||
| } | ||
| func TestDeleteHPALabelFromScaleRef(t *testing.T) { |
There was a problem hiding this comment.
Here need a blank line.
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com> Added tests for hpascaletargetmarker controller Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
anujagrawal699
force-pushed
the
addedTests-controllers/hpascaletargetmarker
branch
from
98264eb to
50634c5
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@chaosi-zju Please take a look. |
Description:
This PR introduces comprehensive unit tests for the HPA Scale Target Marker controller, predicate, and worker components. These tests aim to improve code reliability and facilitate easier maintenance and future development.
Additions:
Test Coverage:
Overall coverage of hpascaletargetmarker controller: 0% to 79.8%
What type of PR is this?
/kind failing-test
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Special notes for your reviewer:
Does this PR introduce a user-facing change?: