Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ut failed in federatedresourcequota #5580

Conversation

XiShanYongYe-Chang
Copy link
Member

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

An intermittent error was found on the master branch,

=== FAIL: pkg/webhook/federatedresourcequota TestValidatingAdmission_Handle/Handle_ExceedResourceLimits_ResourceLimitsExceeded (0.00s)
E0921 06:46:06.951602   28812 validating.go:55] [spec.overall[memory]: Invalid value: "5Gi": overall is less than assignments spec.overall[cpu]: Invalid value: "5": overall is less than assignments]
    validating_test.go:432: Handle() = {Type: Denied, Message: [spec.overall[memory]: Invalid value: "5Gi": overall is less than assignments, spec.overall[cpu]: Invalid value: "5": overall is less than assignments]}, want {Type: Denied, Message: spec.overall[cpu]: Invalid value: "5": overall is less than assignments, spec.overall[memory]: Invalid value: "5Gi": overall is less than assignments}
    --- FAIL: TestValidatingAdmission_Handle/Handle_ExceedResourceLimits_ResourceLimitsExceeded (0.00s)

=== FAIL: pkg/webhook/federatedresourcequota TestValidatingAdmission_Handle (0.00s)

related to the sorting of error messages, and it has been fixed.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: changzhen <changzhen5@huawei.com>
@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Sep 21, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2024
@XiShanYongYe-Chang
Copy link
Member Author

Hi @mohamedawnallah. can you help take a look? Thanks~
/cc @mohamedawnallah

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: mohamedawnallah.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Hi @mohamedawnallah. can you help take a look? Thanks~
/cc @mohamedawnallah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@mohamedawnallah mohamedawnallah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @XiShanYongYe-Chang! LGTM!

@XiShanYongYe-Chang
Copy link
Member Author

/assign @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohamedawnallah, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@karmada-bot karmada-bot merged commit 9864a29 into karmada-io:master Sep 23, 2024
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the fix-ut-failed-in-federatedresourcequota branch December 12, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants