-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests pkg/scheduler/core/common.go #5646
Added tests pkg/scheduler/core/common.go #5646
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5646 +/- ##
==========================================
+ Coverage 35.19% 36.65% +1.45%
==========================================
Files 645 648 +3
Lines 44869 45079 +210
==========================================
+ Hits 15792 16522 +730
+ Misses 27846 27315 -531
- Partials 1231 1242 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e22c015
to
86c54c2
Compare
/assign |
others LGTM |
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com> Added tests for pkg/scheduler/core/common.go Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
86c54c2
to
5dc2355
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
This PR introduces comprehensive unit tests for the common scheduling functions in the scheduler package. The new tests aim to improve code reliability, maintainability, and overall test coverage for core scheduling operations.
Additions:
Test Coverage:
This is can be verified in pkg/scheduler/core directory using
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: