Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests pkg/scheduler/core/common.go #5646

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR introduces comprehensive unit tests for the common scheduling functions in the scheduler package. The new tests aim to improve code reliability, maintainability, and overall test coverage for core scheduling operations.

Additions:

  1. pkg/scheduler/core/common_test.go

Test Coverage:

  1. pkg/scheduler/core/common_test.go : 0% to 95.20%
    This is can be verified in pkg/scheduler/core directory using
go test ./... -coverprofile=coverage.out
go tool cover -html=coverage.out -o coverage.html

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 6, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.65%. Comparing base (6b18b6e) to head (5dc2355).
Report is 40 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5646      +/-   ##
==========================================
+ Coverage   35.19%   36.65%   +1.45%     
==========================================
  Files         645      648       +3     
  Lines       44869    45079     +210     
==========================================
+ Hits        15792    16522     +730     
+ Misses      27846    27315     -531     
- Partials     1231     1242      +11     
Flag Coverage Δ
unittests 36.65% <ø> (+1.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anujagrawal699 anujagrawal699 force-pushed the addedTests-pkg/scheduler/core/common.go branch from e22c015 to 86c54c2 Compare October 6, 2024 15:52
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 6, 2024
@zhzhuang-zju
Copy link
Contributor

/assign

@zhzhuang-zju
Copy link
Contributor

others LGTM

Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>

Added tests for pkg/scheduler/core/common.go

Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
@anujagrawal699 anujagrawal699 force-pushed the addedTests-pkg/scheduler/core/common.go branch from 86c54c2 to 5dc2355 Compare October 11, 2024 09:35
@zhzhuang-zju
Copy link
Contributor

/lgtm
thanks for your work, and ask @XiShanYongYe-Chang for another look

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@karmada-bot karmada-bot merged commit d295576 into karmada-io:master Oct 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants