Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new tests and refractored old in pkg/descheduler/core #5649

Merged

Conversation

anujagrawal699
Copy link
Contributor

@anujagrawal699 anujagrawal699 commented Oct 7, 2024

Description:
This PR introduces new test cases and refractors the old tests for the core components of descheduler. It adds new test cases in pkg/descheduler/core/filter_test.go and refactors old tests in pkg/descheduler/core/helper_test.go to a table-driven approach, thus testing more scenarios. The new tests aim to improve code reliability, maintainability, and overall test coverage for core descheduling operations.

Modifications:

  1. pkg/descheduler/core/filter_test.go:
  • Added new test cases for testing filter bindings.
  • Added new test cases for validating GVK (Group Version Kind) and placement annotations.
  • Introduced tests for handling invalid JSON in placement annotations and various edge cases.
  1. pkg/descheduler/core/helper_test.go:
  • Refactored TestNewSchedulingResultHelper to use table-driven tests, covering more scenarios including invalid status handling.
  • Updated TestSchedulingResultHelper_FillUnschedulableReplicas to use table-driven tests and mock estimators for better coverage.
  • Refactored TestSchedulingResultHelper_GetUndesiredClusters to use table-driven tests.
  • Updated TestGetReadyReplicas to cover more scenarios, including missing fields and invalid JSON.
  • Introduced a mock implementation of UnschedulableReplicaEstimator for testing purposes.

Test Coverage:

  1. pkg/descheduler/core/filter_test.go : 85% to 100%
  2. pkg/descheduler/core/helper_test.go : 76.17% to 98.10%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 7, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.24%. Comparing base (62ae95e) to head (fc8b905).
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5649      +/-   ##
==========================================
+ Coverage   35.21%   35.24%   +0.03%     
==========================================
  Files         645      645              
  Lines       44885    44885              
==========================================
+ Hits        15806    15820      +14     
+ Misses      27847    27839       -8     
+ Partials     1232     1226       -6     
Flag Coverage Δ
unittests 35.24% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@karmada-bot karmada-bot merged commit 4a77d61 into karmada-io:master Oct 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants