-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for pkg/descheduler/descheduler.go #5653
Added tests for pkg/descheduler/descheduler.go #5653
Conversation
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5653 +/- ##
==========================================
+ Coverage 35.23% 35.31% +0.07%
==========================================
Files 645 645
Lines 44891 44891
==========================================
+ Hits 15817 15852 +35
+ Misses 27841 27809 -32
+ Partials 1233 1230 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thannks~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
This pull request enhances the Descheduler component with comprehensive unit tests and improved error handling. The new tests aim to improve code reliability, maintainability, and overall test coverage for descheduling operations.
Added error handling tests in the worker function, including:
Modifications:
Test Coverage:
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: