-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standardize the naming of karmada config in local up method #5679
Conversation
test report: $ kubectl get pods -o wide -n karmada-system
NAME READY STATUS RESTARTS AGE IP NODE NOMINATED NODE READINESS GATES
etcd-0 1/1 Running 0 5m20s 10.244.0.5 karmada-host-control-plane <none> <none>
karmada-aggregated-apiserver-5dc5fc4c56-zztqh 1/1 Running 0 4m1s 10.244.0.7 karmada-host-control-plane <none> <none>
karmada-apiserver-85bb59b977-rghb2 1/1 Running 0 4m31s 172.18.0.5 karmada-host-control-plane <none> <none>
karmada-controller-manager-59f49f6858-l9dff 1/1 Running 0 3m46s 10.244.0.17 karmada-host-control-plane <none> <none>
karmada-descheduler-767fbf4dc5-cs9sm 1/1 Running 0 3m46s 10.244.0.14 karmada-host-control-plane <none> <none>
karmada-kube-controller-manager-6d4cfd68d9-ngdrl 1/1 Running 0 4m1s 10.244.0.6 karmada-host-control-plane <none> <none>
karmada-metrics-adapter-6c44bcf978-kn46v 1/1 Running 0 3m56s 10.244.0.11 karmada-host-control-plane <none> <none>
karmada-scheduler-84bb95cd7c-mtfcl 1/1 Running 0 3m46s 10.244.0.12 karmada-host-control-plane <none> <none>
karmada-scheduler-estimator-member1-76bb76b74f-65qgq 1/1 Running 0 3m27s 10.244.0.21 karmada-host-control-plane <none> <none>
karmada-scheduler-estimator-member2-74986ff67f-w7669 1/1 Running 0 3m22s 10.244.0.22 karmada-host-control-plane <none> <none>
karmada-scheduler-estimator-member3-c8df7788f-f5cjj 1/1 Running 0 3m16s 10.244.0.25 karmada-host-control-plane <none> <none>
karmada-search-7b7d5679cf-twnrb 1/1 Running 0 3m58s 10.244.0.10 karmada-host-control-plane <none> <none>
karmada-webhook-b98dfb68c-wtrgz 1/1 Running 0 3m45s 10.244.0.19 karmada-host-control-plane <none> <none>
$ kubectl get secret -n karmada-system
NAME TYPE DATA AGE
karmada-cert-secret Opaque 14 4m55s
karmada-config-aggregated-apiserver Opaque 1 4m55s
karmada-config-controller-manager Opaque 1 4m54s
karmada-config-descheduler Opaque 1 4m54s
karmada-config-kube-controller-manager Opaque 1 4m54s
karmada-config-metrics-adapter Opaque 1 4m53s
karmada-config-scheduler Opaque 1 4m54s
karmada-config-search Opaque 1 4m53s
karmada-config-webhook Opaque 1 4m53s
member1-kubeconfig Opaque 1 3m
member2-kubeconfig Opaque 1 2m55s
member3-kubeconfig Opaque 1 2m50s
webhook-cert kubernetes.io/tls 2 4m55s |
/cc @RainbowMango ready to review~ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5679 +/- ##
==========================================
+ Coverage 35.21% 38.52% +3.30%
==========================================
Files 645 649 +4
Lines 44885 45133 +248
==========================================
+ Hits 15808 17387 +1579
+ Misses 27846 26415 -1431
- Partials 1231 1331 +100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
021a1f9
to
bcbfeeb
Compare
examples/customresourceinterpreter/karmada-interpreter-webhook-example.yaml
Outdated
Show resolved
Hide resolved
bcbfeeb
to
babbfb2
Compare
0ec2e00
to
92cd2db
Compare
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
92cd2db
to
1b79bba
Compare
@RainbowMango how about do a final check, I'll rebase this and submit next PR~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
In karmada, here are two important secrets, which is mount by most karmada components. One is karmada-cert, which contains a series of cert files like ca.crt, apiserver.crt and so on; another is karmada-kubeconfig, which contains a kubeconfig of karmada-apiserver.
However, in different installation methods, we used inconsistent secret naming or file path naming, which can potentially cause some unnecessary problems, detail refer to #5363.
This PR aims to standardize the naming of karmada config in local up installation method.
Which issue(s) this PR fixes:
Fixes part of #5363
Special notes for your reviewer:
Does this PR introduce a user-facing change?: