Added first part of unit tests for pkg/scheduler

[anujagrawal699]

Description:
This PR significantly enhances the unit tests for the scheduler package and is the first part of unit tests for it. The improvements aim to increase code reliability, maintainability, and test coverage for various scheduler functions.

Note:
The CI tests will fail because the mocks needed for tests are included in second part of unit tests for scheduler module.

Modifications:
pkg/scheduler/scheduler_test.go

Key Improvements:
Added tests for doSchedule, doScheduleBinding, and doScheduleClusterBinding functions.
Added tests for scheduleResourceBindingWithClusterAffinity and scheduleResourceBindingWithClusterAffinities.
Added tests for patchScheduleResultForResourceBinding.

Test Coverage:
pkg/scheduler/scheduler_test.go: 29.71% to 66.90%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

[anujagrawal699]

@XiShanYongYe-Chang Please take a look.

[XiShanYongYe-Chang]

Hi @anujagrawal699 these methods need to be defined:

Error: pkg/scheduler/scheduler_test.go:106:23: undefined: fakeBindingLister
Error: pkg/scheduler/scheduler_test.go:[10](https://github.com/karmada-io/karmada/actions/runs/11304671646/job/31443324973?pr=5680#step:6:11)7:30: undefined: fakeClusterBindingLister
Error: pkg/scheduler/scheduler_test.go:110:22: undefined: fakeBindingLister
Error: pkg/scheduler/scheduler_test.go:[11](https://github.com/karmada-io/karmada/actions/runs/11304671646/job/31443324973?pr=5680#step:6:12)5:29: undefined: fakeClusterBindingLister
Error: pkg/scheduler/scheduler_test.go:[12](https://github.com/karmada-io/karmada/actions/runs/11304671646/job/31443324973?pr=5680#step:6:13)0:17: undefined: mockAlgorithm
Error: pkg/scheduler/scheduler_test.go:253:22: undefined: mockAlgorithm
Error: pkg/scheduler/scheduler_test.go:261:21: undefined: fakeBindingLister
Error: pkg/scheduler/scheduler_test.go:379:22: undefined: mockAlgorithm
Error: pkg/scheduler/scheduler_test.go:387:28: undefined: fakeClusterBindingLister
Error: pkg/scheduler/scheduler_test.go:481:22: undefined: mockAlgorithm
Error: pkg/scheduler/scheduler_test.go:481:22: too many errors (typecheck)

[anujagrawal699]

Hi @anujagrawal699 these methods need to be defined:

Error: pkg/scheduler/scheduler_test.go:106:23: undefined: fakeBindingLister
Error: pkg/scheduler/scheduler_test.go:[10](https://github.com/karmada-io/karmada/actions/runs/11304671646/job/31443324973?pr=5680#step:6:11)7:30: undefined: fakeClusterBindingLister
Error: pkg/scheduler/scheduler_test.go:110:22: undefined: fakeBindingLister
Error: pkg/scheduler/scheduler_test.go:[11](https://github.com/karmada-io/karmada/actions/runs/11304671646/job/31443324973?pr=5680#step:6:12)5:29: undefined: fakeClusterBindingLister
Error: pkg/scheduler/scheduler_test.go:[12](https://github.com/karmada-io/karmada/actions/runs/11304671646/job/31443324973?pr=5680#step:6:13)0:17: undefined: mockAlgorithm
Error: pkg/scheduler/scheduler_test.go:253:22: undefined: mockAlgorithm
Error: pkg/scheduler/scheduler_test.go:261:21: undefined: fakeBindingLister
Error: pkg/scheduler/scheduler_test.go:379:22: undefined: mockAlgorithm
Error: pkg/scheduler/scheduler_test.go:387:28: undefined: fakeClusterBindingLister
Error: pkg/scheduler/scheduler_test.go:481:22: undefined: mockAlgorithm
Error: pkg/scheduler/scheduler_test.go:481:22: too many errors (typecheck)

Thanks @XiShanYongYe-Chang , how can i split mocks in a split of a single file. Should i commit mocks in both parts?

[XiShanYongYe-Chang]

how can i split mocks in a split of a single file. Should i commit mocks in both parts?

In my opinion, the mock parts can be submitted together and do not need to be split separately.

[anujagrawal699]

how can i split mocks in a split of a single file. Should i commit mocks in both parts?

In my opinion, the mock parts can be submitted together and do not need to be split separately.

But if i commit it in one part, the mocks will be undefined in other. Similarly for imports, and unused mocks in a commit will give lint errors.

[XiShanYongYe-Chang]

But if i commit it in one part, the mocks will be undefined in other. Similarly for imports, and unused mocks in a commit will give lint errors.

Add only the mock function required by each pr. When one pr is integrated, rebase the code and delete unnecessary code.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.33%. Comparing base (6b18b6e) to head (0d6d2d7).
Report is 66 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5680      +/-   ##
==========================================
+ Coverage   35.19%   38.33%   +3.13%     
==========================================
  Files         645      649       +4     
  Lines       44869    45133     +264     
==========================================
+ Hits        15792    17302    +1510     
+ Misses      27846    26511    -1335     
- Partials     1231     1320      +89     

Flag	Coverage Δ
unittests	38.33% <ø> (+3.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[anujagrawal699]

@XiShanYongYe-Chang Please take a look!

[XiShanYongYe-Chang]

Thanks~
/assign

[XiShanYongYe-Chang]

Thanks
/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [XiShanYongYe-Chang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment