Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for validateclustertaints.go and validatingmcs.go #5684

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR introduces unit tests for the cluster taints validation and MCS (Multi-Cluster Services) validation functions in the pkg/util/lifted package. These additions aim to increase code reliability, maintainability, and test coverage for the cluster taints and MCS validation logic.

Additions:

  1. pkg/util/lifted/validateclustertaints_test.go
  2. pkg/util/lifted/validatingmcs_test.go

Test Coverage:

  1. pkg/util/lifted/validateclustertaints.go: 0.00% to 100%
  2. pkg/util/lifted/validatingmcs.go: 0.00% to 100%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

…ngmcs.go

Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 12, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.84%. Comparing base (201409c) to head (b30b04f).
Report is 8 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5684      +/-   ##
==========================================
+ Coverage   37.75%   37.84%   +0.08%     
==========================================
  Files         649      649              
  Lines       45133    45133              
==========================================
+ Hits        17042    17081      +39     
+ Misses      26795    26755      -40     
- Partials     1296     1297       +1     
Flag Coverage Δ
unittests 37.84% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

/assign

})
}
}
func TestValidateClusterTaints(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about add a blank line before this test func.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@karmada-bot karmada-bot merged commit e117edc into karmada-io:master Oct 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants