-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for validateclustertaints.go and validatingmcs.go #5684
Added tests for validateclustertaints.go and validatingmcs.go #5684
Conversation
…ngmcs.go Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5684 +/- ##
==========================================
+ Coverage 37.75% 37.84% +0.08%
==========================================
Files 649 649
Lines 45133 45133
==========================================
+ Hits 17042 17081 +39
+ Misses 26795 26755 -40
- Partials 1296 1297 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign |
}) | ||
} | ||
} | ||
func TestValidateClusterTaints(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about add a blank line before this test func.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
This PR introduces unit tests for the cluster taints validation and MCS (Multi-Cluster Services) validation functions in the pkg/util/lifted package. These additions aim to increase code reliability, maintainability, and test coverage for the cluster taints and MCS validation logic.
Additions:
Test Coverage:
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: