Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the error lstat /github/workspace: no such file or directory #5709

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

zhzhuang-zju
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju commented Oct 18, 2024

What type of PR is this?
failed ci link:
https://github.com/karmada-io/karmada/actions/runs/11399514762/job/31718886970

refer to aquasecurity/trivy-action#404 (comment), replacing scan-ref: /github/workspace/ with scan-ref: ${{ github.workspace }}/ to fix the problem.

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
local verification:
https://github.com/zhzhuang-zju/karmada/actions/runs/11400139818/job/31720357994

Does this PR introduce a user-facing change?:


Signed-off-by: zhzhuang-zju <m17799853869@163.com>
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.74%. Comparing base (2fe8570) to head (d41a8cd).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5709      +/-   ##
==========================================
- Coverage   39.74%   39.74%   -0.01%     
==========================================
  Files         650      650              
  Lines       55125    55125              
==========================================
- Hits        21911    21907       -4     
- Misses      31806    31809       +3     
- Partials     1408     1409       +1     
Flag Coverage Δ
unittests 39.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor Author

assign @RainbowMango

@RainbowMango
Copy link
Member

Asking again, is this an official solution?

@zhzhuang-zju
Copy link
Contributor Author

Asking again, is this an official solution?

I'm not certain if this is the official solution, but after investigation, I found that this is a correct approach. The latest version of trivy-action works by executing the trivy command, where the flag scan-ref indicates the reference to be scanned. In our use case, it should be the download path of the Karmada repository. Since the action checkout checks out our repository under $GITHUB_WORKSPACE, setting scan-ref to $GITHUB_WORKSPACE should work without any issues.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2024
@karmada-bot karmada-bot merged commit 21e6dcd into karmada-io:master Oct 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants