Added first part of unit tests for pkg/detector #5711
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/XXL
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5711 +/- ##
==========================================
+ Coverage 39.09% 41.17% +2.07%
==========================================
Files 650 650
Lines 45209 55182 +9973
==========================================
+ Hits 17676 22719 +5043
- Misses 26180 30981 +4801
- Partials 1353 1482 +129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks |
|
@anujagrawal699 Good job! others LGTM |
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com> Added first part of unit tests for pkg/detector Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
anujagrawal699
force-pushed
the
addedTests-pkg/detector-part1
branch
from
6de3624 to
012517d
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
/lgtm |
Description:
This PR significantly enhances the unit tests for the detector package, focusing on the ResourceDetector component. The improvements aim to increase code reliability, maintainability, and test coverage for various detector functions.
Modifications:
Key Improvements:
Test Coverage:
pkg/detector/detector.go: 1.60% to 32.60%
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: