-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit tests for scheduler framework types #5751
Added unit tests for scheduler framework types #5751
Conversation
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5751 +/- ##
==========================================
+ Coverage 41.66% 42.08% +0.41%
==========================================
Files 653 653
Lines 55518 55518
==========================================
+ Hits 23132 23363 +231
+ Misses 30885 30654 -231
Partials 1501 1501
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summarizing 3 Failures:
[FAIL] [Preemption] propagation policy preemption testing when [PropagationPolicy Preemption] PropagationPolicy preempts another (Cluster)PropagationPolicy PropagationPolicy preempts ClusterPropagationPolicy [It] Propagate the deployment with the ClusterPropagationPolicy and then create the PropagationPolicy to preempt it https://github.com/karmada-io/karmada/actions/runs/11552104865/job/32150797730?pr=5751 /retest |
Thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
This PR introduces comprehensive unit tests for scheduler framework types in pkg/util/lifted/scheduler/framework/types.go. These additions significantly improve the test coverage and ensure the reliability of scheduler framework functionality.
Additions::
Test Coverage:
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: