Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for scheduler framework types #5751

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR introduces comprehensive unit tests for scheduler framework types in pkg/util/lifted/scheduler/framework/types.go. These additions significantly improve the test coverage and ensure the reliability of scheduler framework functionality.

Additions::

  1. pkg/util/lifted/scheduler/framework/types_test.go

Test Coverage:

  1. pkg/util/lifted/scheduler/framework/types.go: 26.78% to 89.20%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 28, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.08%. Comparing base (ff6075c) to head (4f160e2).
Report is 65 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5751      +/-   ##
==========================================
+ Coverage   41.66%   42.08%   +0.41%     
==========================================
  Files         653      653              
  Lines       55518    55518              
==========================================
+ Hits        23132    23363     +231     
+ Misses      30885    30654     -231     
  Partials     1501     1501              
Flag Coverage Δ
unittests 42.08% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

Summarizing 3 Failures:
  [FAIL] [Preemption] propagation policy preemption testing when [PropagationPolicy Preemption] PropagationPolicy preempts another (Cluster)PropagationPolicy PropagationPolicy preempts ClusterPropagationPolicy [It] Propagate the deployment with the ClusterPropagationPolicy and then create the PropagationPolicy to preempt it

https://github.com/karmada-io/karmada/actions/runs/11552104865/job/32150797730?pr=5751

/retest

@XiShanYongYe-Chang
Copy link
Member

Thanks~
/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
@karmada-bot karmada-bot merged commit 9c0bd72 into karmada-io:master Oct 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants