-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PurgeMode setting in evection tasks #5821
Support PurgeMode setting in evection tasks #5821
Conversation
@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: mszacillo. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6c3db49
to
7ea9fac
Compare
Signed-off-by: changzhen <changzhen5@huawei.com>
7ea9fac
to
db7982e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5821 +/- ##
=======================================
Coverage 44.84% 44.85%
=======================================
Files 658 658
Lines 53917 53922 +5
=======================================
+ Hits 24180 24187 +7
+ Misses 28169 28167 -2
Partials 1568 1568
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for this.
I'm thinking we can divide up the next two tasks between us? Would you want to update the taint controller and I can update the application failover controllers?
Thanks for your advise, I agree with you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retitle Support PurgeMode setting in evection tasks
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
update GracefulEvictCluster() to set PurgeMode during eviction process
Which issue(s) this PR fixes:
Part of #5788
Special notes for your reviewer:
Does this PR introduce a user-facing change?: