Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PurgeMode setting in evection tasks #5821

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Nov 15, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

update GracefulEvictCluster() to set PurgeMode during eviction process

Which issue(s) this PR fixes:
Part of #5788

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Support PurgeMode setting in evection tasks

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 15, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 15, 2024
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango @mszacillo

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: mszacillo.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @RainbowMango @mszacillo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the update-GracefulEvictCluster-to-set-purgemode branch from 6c3db49 to 7ea9fac Compare November 15, 2024 03:41
Signed-off-by: changzhen <changzhen5@huawei.com>
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the update-GracefulEvictCluster-to-set-purgemode branch from 7ea9fac to db7982e Compare November 15, 2024 04:02
@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 15, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.85%. Comparing base (35b7e8f) to head (db7982e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5821   +/-   ##
=======================================
  Coverage   44.84%   44.85%           
=======================================
  Files         658      658           
  Lines       53917    53922    +5     
=======================================
+ Hits        24180    24187    +7     
+ Misses      28169    28167    -2     
  Partials     1568     1568           
Flag Coverage Δ
unittests 44.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member Author

/retest

Copy link
Contributor

@mszacillo mszacillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this.

I'm thinking we can divide up the next two tasks between us? Would you want to update the taint controller and I can update the application failover controllers?

@XiShanYongYe-Chang
Copy link
Member Author

I'm thinking we can divide up the next two tasks between us? Would you want to update the taint controller and I can update the application failover controllers?

Thanks for your advise, I agree with you.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle Support PurgeMode setting in evection tasks
/lgtm
/approve

@karmada-bot karmada-bot changed the title update GracefulEvictCluster() to set PurgeMode during eviction process Support PurgeMode setting in evection tasks Nov 16, 2024
@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2024
@karmada-bot karmada-bot merged commit 35a8237 into karmada-io:master Nov 16, 2024
18 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the update-GracefulEvictCluster-to-set-purgemode branch November 28, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants