-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build PreservedLabelState when triggering evition in RB/CRB application controller #5887
Build PreservedLabelState when triggering evition in RB/CRB application controller #5887
Conversation
/cc @RainbowMango |
30cd923
to
315994b
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5887 +/- ##
==========================================
- Coverage 46.31% 46.29% -0.03%
==========================================
Files 663 663
Lines 54605 54753 +148
==========================================
+ Hits 25291 25346 +55
- Misses 27690 27778 +88
- Partials 1624 1629 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
315994b
to
4a5a80d
Compare
aaecd46
to
5bfbd6d
Compare
pkg/controllers/applicationfailover/crb_application_failover_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: changzhen <changzhen5@huawei.com>
5bfbd6d
to
46dbf07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Build PreservedLabelState when triggering evition in RB/CRB application controller
Which issue(s) this PR fixes:
Part of #5788
Special notes for your reviewer:
Does this PR introduce a user-facing change?: