Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build PreservedLabelState when triggering evition in RB/CRB application controller #5887

Merged

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Nov 27, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Build PreservedLabelState when triggering evition in RB/CRB application controller

Which issue(s) this PR fixes:
Part of #5788

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-controller-manager: build PreservedLabelState when triggering eviction in RB/CRB application controller

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 27, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 27, 2024
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.67568% with 27 lines in your changes missing coverage. Please review.

Project coverage is 46.29%. Comparing base (f168061) to head (5bfbd6d).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controllers/applicationfailover/common.go 84.14% 10 Missing and 3 partials ⚠️
pkg/apis/work/v1alpha2/binding_types_helper.go 52.94% 8 Missing ⚠️
...ionfailover/crb_application_failover_controller.go 50.00% 2 Missing and 1 partial ⚠️
...tionfailover/rb_application_failover_controller.go 50.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5887      +/-   ##
==========================================
- Coverage   46.31%   46.29%   -0.03%     
==========================================
  Files         663      663              
  Lines       54605    54753     +148     
==========================================
+ Hits        25291    25346      +55     
- Misses      27690    27778      +88     
- Partials     1624     1629       +5     
Flag Coverage Δ
unittests 46.29% <75.67%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@RainbowMango RainbowMango added this to the v1.12 milestone Nov 27, 2024
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 27, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the build-PreservedLabelState branch 2 times, most recently from aaecd46 to 5bfbd6d Compare November 28, 2024 01:29
Signed-off-by: changzhen <changzhen5@huawei.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@karmada-bot karmada-bot merged commit 1b8d09c into karmada-io:master Nov 28, 2024
19 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the build-PreservedLabelState branch November 28, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants