-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup works from cluster if purgemode is immediately #5889
Cleanup works from cluster if purgemode is immediately #5889
Conversation
Signed-off-by: mszacillo <mszacillo@bloomberg.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5889 +/- ##
==========================================
+ Coverage 46.28% 46.31% +0.02%
==========================================
Files 663 663
Lines 54707 54756 +49
==========================================
+ Hits 25321 25360 +39
- Misses 27760 27769 +9
- Partials 1626 1627 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @XiShanYongYe-Chang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot~
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Within the binding controller and cluster binding controller we find and remove orphan works by checking the works against the existing clusters.
Existing clusters are populated by joining the resource binding's
spec.Clusters
field with any clusters that are found in the GracefulEvictionTasks. With the addition of PurgeMode, we should now check that the PurgeMode is not Immediately when populating the existing clusters.If the cluster has an eviction task with Immediately purgeMode, we should treat the work on that cluster as an orphan and evict it.
Which issue(s) this PR fixes:
Part of #5788
Does this PR introduce a user-facing change?: