Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup works from cluster if purgemode is immediately #5889

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

mszacillo
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Within the binding controller and cluster binding controller we find and remove orphan works by checking the works against the existing clusters.

Existing clusters are populated by joining the resource binding's spec.Clusters field with any clusters that are found in the GracefulEvictionTasks. With the addition of PurgeMode, we should now check that the PurgeMode is not Immediately when populating the existing clusters.

If the cluster has an eviction task with Immediately purgeMode, we should treat the work on that cluster as an orphan and evict it.

Which issue(s) this PR fixes:
Part of #5788

Does this PR introduce a user-facing change?:

Cleanup works from clusters with eviction task when purge mode is immediately

Signed-off-by: mszacillo <mszacillo@bloomberg.net>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 28, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.31%. Comparing base (3783eaf) to head (082fe7c).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5889      +/-   ##
==========================================
+ Coverage   46.28%   46.31%   +0.02%     
==========================================
  Files         663      663              
  Lines       54707    54756      +49     
==========================================
+ Hits        25321    25360      +39     
- Misses      27760    27769       +9     
- Partials     1626     1627       +1     
Flag Coverage Δ
unittests 46.31% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @XiShanYongYe-Chang

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@karmada-bot karmada-bot merged commit c8b033d into karmada-io:master Nov 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants