Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priorityClassName in PropagationPolicy & ClusterPropagationPolicy #5962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seanlaii
Copy link
Contributor

What type of PR is this?
/kind api-change
/kind feature

What this PR does / why we need it:
Add PriorityClassName to PropagationPolicy & ClusterPropagationPolicy.

Which issue(s) this PR fixes:
Part of #5961

Special notes for your reviewer:

  • The PriorityClassName field follows the same pattern as Kubernetes PodSpec.PriorityClassName
  • Falls back to global default PriorityClass if unspecified, similar to Pod priority behavior
  • Implementation preserves backward compatibility as the field is optional

Does this PR introduce a user-facing change?:

Add PriorityClassName field to PropagationPolicy and ClusterPropagationPolicy, allowing users to specify priority and preemption behavior through PriorityClass objects. This provides more flexible and standardized priority management for resource propagation.

Signed-off-by: wei-chenglai <qazwsx0939059006@gmail.com>
@karmada-bot karmada-bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Dec 19, 2024
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 19, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.18%. Comparing base (8d89d77) to head (2d81d50).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5962   +/-   ##
=======================================
  Coverage   48.17%   48.18%           
=======================================
  Files         664      664           
  Lines       54799    54799           
=======================================
+ Hits        26399    26403    +4     
+ Misses      26684    26681    -3     
+ Partials     1716     1715    -1     
Flag Coverage Δ
unittests 48.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants