Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5960: Fix panic when validating ResourceInterpreterWebhookConfiguration with unspecified service port #5967

Open
wants to merge 1 commit into
base: release-1.12
Choose a base branch
from

Conversation

seanlaii
Copy link
Contributor

@seanlaii seanlaii commented Dec 22, 2024

Cherry pick of #5960 on release-1.12.
#5960: fix validate panic when
Part of #5964
For details on the cherry pick process, see the cherry pick requests page.

`karmada-webhook`: Fixed panic when validating ResourceInterpreterWebhookConfiguration with unspecified service port.

…ooks[*].clientConfig.service.port is nil

Signed-off-by: changzhen <changzhen5@huawei.com>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chaunceyjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 22, 2024
@seanlaii seanlaii changed the title Automated cherry pick of #5960: fix validate panic when Automated cherry pick of #5960: fix validate panic when validating ResourceInterpreterWebhookConfiguration with unspecified service port Dec 22, 2024
@seanlaii seanlaii changed the title Automated cherry pick of #5960: fix validate panic when validating ResourceInterpreterWebhookConfiguration with unspecified service port Automated cherry pick of #5960: Fix panic when validating ResourceInterpreterWebhookConfiguration with unspecified service port Dec 22, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.50%. Comparing base (7efb13b) to head (096e936).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.12    #5967   +/-   ##
=============================================
  Coverage         46.49%   46.50%           
=============================================
  Files               663      663           
  Lines             54736    54748   +12     
=============================================
+ Hits              25452    25461    +9     
- Misses            27657    27660    +3     
  Partials           1627     1627           
Flag Coverage Δ
unittests 46.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants