-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue of missing workqueue metrics in the Karmada controller #5972
Fix the issue of missing workqueue metrics in the Karmada controller #5972
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5972 +/- ##
==========================================
+ Coverage 48.23% 48.26% +0.02%
==========================================
Files 664 665 +1
Lines 54749 54788 +39
==========================================
+ Hits 26410 26444 +34
- Misses 26624 26630 +6
+ Partials 1715 1714 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4c493bd
to
b0ba3cb
Compare
/retest |
b0ba3cb
to
5ed3932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
cc @lxtywypc |
5ed3932
to
8f4414b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but please
- organize the tests case by order
normal cases
-->abnormal cases
, and make sure each test has a meaningful name. - Please provide a test report, to show the metrics are emitted as expected from both
karmada-controller-manager
andkarmada-agent
.
pkg/resourceinterpreter/customized/webhook/serviceresolvers_test.go
Outdated
Show resolved
Hide resolved
pkg/resourceinterpreter/customized/webhook/serviceresolvers_test.go
Outdated
Show resolved
Hide resolved
pkg/resourceinterpreter/customized/webhook/serviceresolvers_test.go
Outdated
Show resolved
Hide resolved
pkg/resourceinterpreter/customized/webhook/serviceresolvers_test.go
Outdated
Show resolved
Hide resolved
pkg/resourceinterpreter/customized/webhook/serviceresolvers_test.go
Outdated
Show resolved
Hide resolved
pkg/resourceinterpreter/customized/webhook/serviceresolvers_test.go
Outdated
Show resolved
Hide resolved
Test cases are organized by service type. If all abnormal cases are placed at the end, the organization relationship will be broken. |
8f4414b
to
a029089
Compare
|
Signed-off-by: changzhen <changzhen5@huawei.com>
a029089
to
5bd3d01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
wait @lxtywypc for a while
Test results were as expected @RainbowMango
|
Thanks @CharlesQQ for the feedback. |
I have finished test in our environment, it works well. LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Thanks for the confirmation.
Now, let's fix this on master, and then this will be backported to all affected releases.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…k-of-#5972-upstream-release-1.12 Automated cherry pick of #5972: fix the issue of missing workqueue metrics in the Karmada controller
…k-of-#5972-upstream-release-1.11 Automated cherry pick of #5972: fix the issue of missing workqueue metrics in the Karmada controller
…k-of-#5972-upstream-release-1.10 Automated cherry pick of #5972: fix the issue of missing workqueue metrics in the Karmada controller
What type of PR is this?
/kind bug
What this PR does / why we need it:
This pr removes the apiserver dependency on resourceinterpreter. For details about why to remove the apiserver reference, see #5945 (comment).
This pr is part of #5945. It focuses on removing only the dependency of the apiserver repository, thus directly solving the problem of missing workqueue metrics and facilitating the prcherry-pick to the previous version (v1.10, v1.11 and v1.12).
Which issue(s) this PR fixes:
Fixes #5696
Part of #5954
Special notes for your reviewer:
Does this PR introduce a user-facing change?: