add metrics for scheduler #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
kind/feature
qianjun1993
force-pushed
the
metrics
branch
from
e1db154 to
b8445ba
Compare
|
refer to: #695 (comment) |
|
Hi @qianjun1993 |
|
I get it from my side: All metrics |
|
I noticed you used the |
qianjun1993
force-pushed
the
metrics
branch
2 times, most recently
from
6f30d20 to
8ed7dcc
Compare
|
/assign |
qianjun1993
force-pushed
the
metrics
branch
from
8ed7dcc to
7a36f66
Compare
| ClusterNotReady = "ClusterNotReady" | ||
| ) | ||
|
|
||
| // BindingSchedule can records a scheduling attempt and the duration |
There was a problem hiding this comment.
Suggested change
| // BindingSchedule can records a scheduling attempt and the duration | |
| // BindingSchedule can record a scheduling attempt and the duration |
pkg/scheduler/scheduler.go
Outdated
| var err error | ||
| switch s.getScheduleType(key.(string)) { | ||
| case FirstSchedule: | ||
| err = s.scheduleOne(key.(string)) | ||
| klog.Infof("Start scheduling binding(%s)", key.(string)) | ||
| metrics.BindingSchedule("FirstSchedule", metrics.SinceInSeconds(start), err) |
There was a problem hiding this comment.
Why not use the const FirstSchedule, like string(FirstSchedule)?
pkg/scheduler/metrics/metrics.go
Outdated
| prometheus.CounterOpts{ | ||
| Subsystem: SchedulerSubsystem, | ||
| Name: "queue_incoming_bindings_total", | ||
| Help: "Number of pods added to scheduling queues by event type.", |
| scheduleAttempts.WithLabelValues(result, scheduleType).Inc() | ||
| } | ||
|
|
||
| // ScheduleStep can records each scheduling duration |
There was a problem hiding this comment.
Suggested change
| // ScheduleStep can records each scheduling duration | |
| // ScheduleStep can record each scheduling step duration. |
qianjun1993
force-pushed
the
metrics
branch
from
7a36f66 to
72ef4cc
Compare
|
/lgtm But please resolve the conflicts. |
Signed-off-by: junqian <junqian@tencent.com>
qianjun1993
force-pushed
the
metrics
branch
from
72ef4cc to
226b48b
Compare
|
/lgtm /hold |
karmada-bot
added
do-not-merge/hold
RainbowMango
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
karmada-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: junqian junqian@tencent.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes First Four part of # 695
Special notes for your reviewer:
Does this PR introduce a user-facing change?: