Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #164

Closed
wants to merge 1 commit into from
Closed

Update dependencies #164

wants to merge 1 commit into from

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Sep 8, 2022

What type of PR is this?

Add one of the following kinds:

/kind feature

Which issue(s) this PR fixes:
resolve #163

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 8, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 8, 2022
RainbowMango
RainbowMango reviewed Sep 9, 2022
View reviewed changes
package.json
@@ -23,7 +23,7 @@
"@emotion/react": "^11.10.4",
"@emotion/styled": "^11.10.4",
"@mdx-js/react": "^1.6.22",
"@mui/material": "^5.10.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating this module does not fix any item address at #79.
Why are we going to do this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a small dependency update
if not needed, then I will close this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are few descriptions, I can't tell why we need this update.

@Arhell
Update dependencies
7294fb8 
Signed-off-by: Arhell <arhell333@gmail.com>
@Arhell Arhell marked this pull request as ready for review September 10, 2022 07:08
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2022
@Arhell Arhell closed this Sep 12, 2022
@Arhell Arhell deleted the upd branch September 12, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango left review comments

@pigletfly pigletfly Awaiting requested review from pigletfly

@rgrupesh rgrupesh Awaiting requested review from rgrupesh

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update dependencies
3 participants
@Arhell @karmada-bot @RainbowMango